Probably one of the best improvements you can make, I fitted a complete new Bilstein spring and shock set to my old 120,000 mile E46 330i touring, it was like driving a brand new car.
I agree, i fitted a full set of Koni uprated springs & shocks to my 170k mile old mk4 golf and the difference was amazing. Only cost me £250 if i remember rightly for the full set of suspension.